Adar Dembo has submitted this change and it was merged. Change subject: bshuf_block: some low-hanging-fruit optimizations on write path ......................................................................
bshuf_block: some low-hanging-fruit optimizations on write path Rather than adding an element at a time and calling the virtual 'IsBlockFull()' function, we predetermine how many elements we will accept. This allows a much simpler batched 'Add()' implementation. This sped up the write side of cfile-test's 100M-integer test about 2x. Change-Id: Ia895f7731e5371967782ef9cb176a9d493894a83 Reviewed-on: http://gerrit.cloudera.org:8080/5195 Reviewed-by: Dan Burkert <danburk...@apache.org> Tested-by: Kudu Jenkins --- M src/kudu/cfile/bshuf_block.h 1 file changed, 10 insertions(+), 26 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia895f7731e5371967782ef9cb176a9d493894a83 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
