Alexey Serbin has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/error_collector.cc File src/kudu/client/error_collector.cc: Line 41: void ErrorCollector::SetMaxMemSize(size_t size_bytes) { > Yep, this part I skipped partly because I was not sure what behavior we wan A small addition: if the limit is increased, it's also necessary to make sure no errors dropped so far. Otherwise the set of accumulated errors would contain a hole -- we don't want that, right? -- To view, visit http://gerrit.cloudera.org:8080/5308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9fe3e83bab2a0b703b685ec7f3bb1db1601e5f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
