Alexey Serbin has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/client.h File src/kudu/client/client.h: Line 1520: /// By default, when a session is created, there is no limit on maximum size. > can you comment on what happens when this limit is reached? Done Line 1521: /// > might be worth commenting that errors contain error messages that are poten Done Line 1524: /// where @c 0 means 'unlimited'. > is negative also unlimited, or what happens? The 'size_t' is an unsigned type, so I don't think talking about negative values is relevant here. However, you make a good point: may be, it's worth to use a signed type instead. -- To view, visit http://gerrit.cloudera.org:8080/5308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9fe3e83bab2a0b703b685ec7f3bb1db1601e5f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
