Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5345/2/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 1320: NO_FATALS(DeleteTable(w.table_name(), ON_ERROR_DO_NOT_DUMP_STACKS)); > Hmmm, I haven't looked at scan codepaths, but at high level I would guess d Checking another server is only for so-called 'fault-tolerant' scans: ORDERED scans or scans explicitly marked fault-tolerant with KuduScanner::SetFaultTolerant() method. Other scans are not retried at other servers. So, this test provide necessary coverage, as I understand. PS2, Line 1324: vector<string> tablets; : do { : SleepFor(MonoDelta::FromMilliseconds(256)); : tablets = inspect_->ListTablets(); : } while (!tablets.empty()); > There are bunch of utils in cluster_itest_util.cc, you might want to use re I didn't find better alternative for this simple check among those methods. What exact method you could recommend? -- To view, visit http://gerrit.cloudera.org:8080/5345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983e68862b5535f2f95eedd41850a8a88e95e69c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
