Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test ......................................................................
Patch Set 6: Code-Review+1 (5 comments) I will defer +2 to David, LGTM, few nits. http://gerrit.cloudera.org:8080/#/c/5345/2/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 1320: // Setup batch size to be small enough to guarantee the scan will not fetch > Another piece of information which helps to understand that impala was issu I see, thank you for explaining. PS2, Line 1324: ASSERT_TRUE(scanner.HasMoreRows()); : KuduScanBatch batch; : ASSERT_OK(scanner.NextBatch(&batch)); : size_t row_count = batch.NumRows(); : > I didn't find better alternative for this simple check among those methods. Since you are checking for existence of tablets on the cluster, and not specific TS, this seems fine. Personally, I would have preferred to go to master with RPC for eg, itest::GetTableLocations() or something like that because it fully reflects the table's state on the cluster. inspect_ reflects only on-disk contents on the servers, but the cleanup may not be complete by then. http://gerrit.cloudera.org:8080/#/c/5345/6/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: PS6, Line 1316: shared_ptr Nit: we could use sp::shared_ptr here to indicate that it's not C++ shared_ptr and keep "shared_ptr" reserved for C++ standard library one. PS6, Line 1331: ON_ERROR_DO_NOT_DUMP_STACKS Do we want to put a comment here as to why we wanted to avoid dumping stacks ? PS6, Line 1357: StopCluster Nit: Wasn't AssertNoCrashes above sufficient ? Or is this added as a good practice ? -- To view, visit http://gerrit.cloudera.org:8080/5345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983e68862b5535f2f95eedd41850a8a88e95e69c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
