Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/5340/3/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 294: SubstituteInFlags(flags, i)); > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/5340/1/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: Line 362: stop_background_threads_latch_.CountDown(); > 1) We're not joining on the new thread at all. Done http://gerrit.cloudera.org:8080/#/c/5340/1/src/kudu/util/logging.cc File src/kudu/util/logging.cc: Line 333: continue; > Before committing to this approach I'd like to understand why Impala does i Here is the gerrit introducing log rotation into Impala: https://gerrit.sjc.cloudera.com/#/c/5706. I scanned it but didn't see anything but style comments. I don't think we are committing to this approach permanently, but I think there is some amount of risk that we haven't thought about some downside to the alternative, and this is an extremely difficult thing to test since it's so tied into glog / process global state. http://gerrit.cloudera.org:8080/#/c/5340/4/src/kudu/util/logging.cc File src/kudu/util/logging.cc: Line 18: > Since you're changing the system includes, mind splitting out the real "sys Done -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f81638a6dfcf134665322f091ff26d29640fd9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
