Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5340/9/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: Line 19: > nit: consider adding <algorithm> for std::min() Done http://gerrit.cloudera.org:8080/#/c/5340/9/src/kudu/util/logging.cc File src/kudu/util/logging.cc: PS9, Line 386: RETURN_NOT_OK(env->DeleteFile(logfile.second)); > Nit: may be, the best effort would be better here, i.e. remember there was I considered this originally, but I think the extra complexity isn't worth the upside. Plus it would mean that we delete log files out of order, which could be unexpected. -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f81638a6dfcf134665322f091ff26d29640fd9 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
