David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement ......................................................................
Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/5300/15/src/kudu/consensus/time_manager.cc File src/kudu/consensus/time_manager.cc: PS15, Line 144: waiters_.push_back > If I'm not mistaken, AdvanceSafeTimeAndWakeUpWaitersUnlocked() is trying to see mvcc-cc this is the same logic (an argument could be made for refactoring but expediency is key here). If AdvanceSafeTimeAndWakeUpWaitersUnlocked is going to access the element it's going to do so while we're in this method so the element is alive -- To view, visit http://gerrit.cloudera.org:8080/5300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb2b1d2590ed7ead6f1980f9572be10444bb81b Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
