Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement ......................................................................
Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/5300/15/src/kudu/consensus/time_manager.cc File src/kudu/consensus/time_manager.cc: PS15, Line 46: external_consistency_mode > it has a default though. doesn't that mean it's always set? Yep, as I understand that means the field will have the default value if not explicitly. So, it's safe, I think. -- To view, visit http://gerrit.cloudera.org:8080/5300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb2b1d2590ed7ead6f1980f9572be10444bb81b Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
