Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON ......................................................................
KUDU-1624. Fix data race in Trace::MetricsToJSON We were accessing child_traces_ without the appropriate lock. rpc_stub-test failed 2/200 times before with this race, and passed 1000/1000 after the fix. Change-Id: If72ccf3fc8e0d727f2c40b978889597e89ad891a Reviewed-on: http://gerrit.cloudera.org:8080/5419 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/util/trace.cc 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Mike Percy: Looks good to me, approved Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72ccf3fc8e0d727f2c40b978889597e89ad891a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
