Todd Lipcon has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5419/1/src/kudu/util/trace.cc File src/kudu/util/trace.cc: Line 231: e.second->MetricsToJSON(jw); > We'll be making local copies of child_traces as we recurse, protected by th I don't think it would be invalid, because for any given trace, we only snapshot its child_traces_ once. -- To view, visit http://gerrit.cloudera.org:8080/5419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If72ccf3fc8e0d727f2c40b978889597e89ad891a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
