Todd Lipcon has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5464/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: PS2, Line 81: * : * <p>Though we currently do not have transactional support, users will be forced : * to use a {@code AsyncKuduSession} to instantiate reads as well as writes. This will make : * it more straightforward to add R/W transactions in the future without : * significant modifications to the API. unrelated to your patch: is this paragraph true? http://gerrit.cloudera.org:8080/#/c/5464/2/java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java File java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java: PS2, Line 58: This is because there may be a race between the 2 available : * mutation buffers (2 is currently hard-coded), each of which can perform a network flush at : * the same time. I don't like phrasing this as a race -- makes it sound like a bug rather than just something that falls out of the semantics here. In the user-facing docs I think we should just specify the behavior and not try to explain the internal details which are more likely to confuse than aid. http://gerrit.cloudera.org:8080/#/c/5464/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1228: ace between the number of configured : /// mutation buffers, each of which can perform a network flush at the : /// same time. see comment elsewhere, "race" sounds like a bug. PS2, Line 1245: This is because there may be a : /// race between the number of configured mutation buffers, each of which : /// can perform a network flush at the same time. same -- To view, visit http://gerrit.cloudera.org:8080/5464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65215d833c65e54fcf080d61adc5f6ed3d303224 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
