Alexey Serbin has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering ......................................................................
Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/5464/4//COMMIT_MSG Commit Message: PS4, Line 7: docs: KUDU-1767. Document possible client op reordering nit: it seems KUDU-1767 is not exactly about documenting write operations re-ordering. Does it make sense to remove the mention about KUDU-1767 from the short description? As an alternative, may be create a separate Jira item on documenting that or just mention KUDU-1767 in the long description of this commit. http://gerrit.cloudera.org:8080/#/c/5464/3/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: PS3, Line 217: In `AUTO_ nit: noticeable http://gerrit.cloudera.org:8080/#/c/5464/4/java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java File java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java: PS4, Line 57: flush : * simultaneously nit: may be, stop defining flush via flush and replace with '... in this mode multiple write operations may be sent to the server in parallel.' PS4, Line 165: FlushMode#AUTO_FLUSH_BACKGROUND IIRC this is also true for MANUAL_FLUSH mode as well. http://gerrit.cloudera.org:8080/#/c/5464/4/src/kudu/client/client.h File src/kudu/client/client.h: PS4, Line 1227: to Kudu nit: consider dropping that PS4, Line 1227: This : /// is because the buffers may flush concurrently nit: consider describing what it means in terms of write operations, may be adding ... may flush concurrently, so multiple write operations may be sent to the server in parallel. PS4, Line 1242: to Kudu nit: consider dropping PS4, Line 1243: This is because the buffers may : /// flush concurrently nit: ditto with explaining that in terms of write operations sent to the server. -- To view, visit http://gerrit.cloudera.org:8080/5464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65215d833c65e54fcf080d61adc5f6ed3d303224 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
