Todd Lipcon has posted comments on this change. Change subject: external_mini_cluster: check for leaks before killing servers ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5501/6/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: Line 108: #ifndef LSAN_ENABLED > Nit: I think it'd be simpler to elide LSAN_ENABLED and just move the code b The problem then is that the '#else' would apply to the outer #if instead of the inner one. Line 113: resp->set_found_leaks(__lsan_do_recoverable_leak_check()); > I don't suppose we could also report more information on the leak itself? S __lsan_do_recoverable_leak_check dumps the stacks to the output in the same way that the normal end-of-process one does -- To view, visit http://gerrit.cloudera.org:8080/5501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6c38281e35e8300e849f92e91d6955a8d735bf Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
