Todd Lipcon has submitted this change and it was merged. Change subject: external_mini_cluster: check for leaks before killing servers ......................................................................
external_mini_cluster: check for leaks before killing servers This improves the ExternalMiniCluster when running with LeakSanitizer enabled so that, before killing subprocesses, it runs a leak check. Without this, it's hard for us to know if there are any leaks in code paths that are covered only by EMC-based tests. Tested by manually inserting a leak into the tablet server and verifying that an EMC test failed. Change-Id: I9b6c38281e35e8300e849f92e91d6955a8d735bf Reviewed-on: http://gerrit.cloudera.org:8080/5501 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/server/generic_service.cc M src/kudu/server/generic_service.h M src/kudu/server/server_base.proto M src/kudu/util/debug/leak_annotations.h 6 files changed, 97 insertions(+), 14 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b6c38281e35e8300e849f92e91d6955a8d735bf Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
