Todd Lipcon has posted comments on this change. Change subject: tls: move setting of verification modes into TlsHandshake ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5839/1/src/kudu/security/tls_handshake-test.cc File src/kudu/security/tls_handshake-test.cc: PS1, Line 142: ASSERT_STR_MATCHES(s. > does it make sense to check for the status code as well? sure will do PS1, Line 155: // It should still succeed with verification off, as well. : ASSERT_OK(RunHandshake(TlsVerificationMode::VERIFY_NONE, : TlsVerificationMode::VERIFY_NONE)); > Why is it necessary to verify this as well here? As I see, this case seems fair enough http://gerrit.cloudera.org:8080/#/c/5839/1/src/kudu/security/tls_handshake.h File src/kudu/security/tls_handshake.h: PS1, Line 65: use > nit: remove I think this is correct as is. Parse as: must be initialized (before use) (using TlsContext::InitiateHandshake) -- To view, visit http://gerrit.cloudera.org:8080/5839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37cbc20b1a70a7469a2a2f43702599b1b55ff294 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
