Alexey Serbin has posted comments on this change. Change subject: tls: move setting of verification modes into TlsHandshake ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5839/1/src/kudu/security/tls_handshake-test.cc File src/kudu/security/tls_handshake-test.cc: PS1, Line 134: Test_ClientNone_ServerSelfSigned It might make sense to add a test for expired certificates as well. Probably, it's better to do that in a separate changelist. If so, consider adding a TODO for expired certs. -- To view, visit http://gerrit.cloudera.org:8080/5839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37cbc20b1a70a7469a2a2f43702599b1b55ff294 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
