Dan Burkert has posted comments on this change. Change subject: [security] do actual token signing/verification ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc File src/kudu/security/token_signing_key.cc: Line 35: CHECK(pb_.has_rsa_key_der()); > It does not make much sense to me: there are multiple CHECK() statements in > there are multiple CHECK() statements in TokenVerifier::ImportPublicKeys() That's definitely an issue, thanks for pointing it out. I'll submit a patch for change ImportPublicKeys to return a Status. In this case, though, theres no way to change the constructor to return a Status, so I think this needs a Status-returning Init function. -- To view, visit http://gerrit.cloudera.org:8080/5812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf035c64032320a450731ae921e92615bf2efd98 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
