Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/5812/11/src/kudu/security/token_signing_key.h File src/kudu/security/token_signing_key.h: Line 35: class TokenSigningPublicKey { > would be good to keep a comment saying 'This class is thread-safe after Ini Added the comment for VerifySignature(). http://gerrit.cloudera.org:8080/#/c/5812/11/src/kudu/security/token_verifier.cc File src/kudu/security/token_verifier.cc: PS11, Line 56: copy construction > I guess this is a bit out of date -- probably should say just say 'construc Done -- To view, visit http://gerrit.cloudera.org:8080/5812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf035c64032320a450731ae921e92615bf2efd98 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
