Alexey Serbin has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS3, Line 50: char* str = X509_NAME_oneline(name, nullptr, 0); : string ret(str); : free(str); : return ret; What if allocate some long buffer (4K) on the stack and then pass it into the X509_NAME_oneline() to avoid extra malloc/free pair? http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: PS3, Line 112: ERR_clear_error(); What is it for? http://gerrit.cloudera.org:8080/#/c/5845/2/src/kudu/security/tls_context.h File src/kudu/security/tls_context.h: PS2, Line 46: the nit: drop -- To view, visit http://gerrit.cloudera.org:8080/5845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb82427aea5f1bd29bad7529f2d54638b90811e2 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
