Todd Lipcon has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5845/1/src/kudu/security/tls_context.h File src/kudu/security/tls_context.h: Line 68: Status LoadCertificateAndKey(const std::string& certificate_path, > Is the plan to eventually remove these? I can't think of a reason they wou yea, I think it's worth considering removing them. I left them since messenger.cc is still calling them to handle the flag-based paths it can be provided, but we could just as well move the wrapper implementation there. -- To view, visit http://gerrit.cloudera.org:8080/5845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb82427aea5f1bd29bad7529f2d54638b90811e2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
