Adar Dembo has posted comments on this change.

Change subject: thirdparty: patch cmake to avoid select() when reading from 
subprocess pipes
......................................................................


Patch Set 1:

> hrm... is there any patch upstream in cmake to switch from select()
 > to poll() or something instead? Adding 5 seconds to the rebuild is
 > a little annoying. (for me an incremental ninja is only a second or
 > two typically)

I didn't look hard; the cmake maintainers seem to think that the right fix is 
to switch to libuv for subprocess handling.

-- 
To view, visit http://gerrit.cloudera.org:8080/5857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33596a36c1f974078140360cb62b01f58211b44c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to