Adar Dembo has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes ......................................................................
Patch Set 1: Code-Review-2 MJ and I discussed this further and decided it might be best to constrain the patch to SLES 12 SP0 only after all. I alluded to this being difficult in the commit message, but at the time I was thinking of performing the check in CPP inside cmake. Instead, we could do it in download-thirdparty.sh to decide whether to apply the patch or not. There we can take advantage of /etc/SuSE-release for the check. I'll update this with that approach tomorrow. -- To view, visit http://gerrit.cloudera.org:8080/5857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33596a36c1f974078140360cb62b01f58211b44c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
