Dan Burkert has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6029/3/src/kudu/tablet/tablet-scan-correctness-test.cc File src/kudu/tablet/tablet-scan-correctness-test.cc: PS3, Line 34: NULL, NULL prefer using 'nullptr' to NULL. Line 56: lower = std::max(static_cast<size_t>(0), lower); Is this cast necessary? If so, try switching the argument order and trying. Line 99: LOG(INFO) << "Nrows: " << nrows_ This should probably be a SCOPED_TRACE to cut down on test noise. SCOPED_TRACE only prints on failure. Line 208: CHECK_OK(row.SetFloat(1, static_cast<float>(i % cardinality))); I think a lot of these casts should be unnecessary, in which case leave them off. C++ has pretty 'generous' implicit conversions. -- To view, visit http://gerrit.cloudera.org:8080/6029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
