David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/cfile/binary_dict_block.h File src/kudu/cfile/binary_dict_block.h: PS4, Line 135: virtual no need for "virtual" if you add "override" http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/cfile/binary_plain_block.h File src/kudu/cfile/binary_plain_block.h: PS4, Line 105: virtual same http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc File src/kudu/tablet/tablet-scan-correctness-test.cc: PS4, Line 400: INSTANTIATE_TEST_CASE_P(TabletScanCorrectnessTest, TabletFloatCorrectnessTest, : ::testing::Values(PLAIN_ENCODING, BIT_SHUFFLE)); : INSTANTIATE_TEST_CASE_P(TabletScanCorrectnessTest, TabletInt32CorrectnessTest, : ::testing::Values(PLAIN_ENCODING, BIT_SHUFFLE, RLE)); : INSTANTIATE_TEST_CASE_P(TabletScanCorrectnessTest, TabletInt64CorrectnessTest, : ::testing::Values(PLAIN_ENCODING, BIT_SHUFFLE)); I commented the same in the other patch, but none of these encodings actually exercise the decoder-level eval path, right? is this being tested somewhere else? -- To view, visit http://gerrit.cloudera.org:8080/6029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
