David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns ......................................................................
Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: PS2, Line 499: is search fo NULLs rephrase/typo PS2, Line 497: // Cases where the selection vector can be cleared: : // 1. There is a read_default and it does not satisfy the predicate : // 2. There is no read_default and the predicate is search fo NULLs move this below the next if block PS2, Line 506: DecoderEvalNotDisabled not your fault, but this means DecoderEvalEnabled, right? we should rename that (in another patch if you want to do it) PS2, Line 506: if (ctx->DecoderEvalNotDisabled() && : !ctx->pred()->EvaluateCell(typeinfo_->physical_type(), value_)) { : SelectionVectorView sel_view(ctx->sel()); : sel_view.ClearBits(dst->nrows()); : } no need to set cell values if value doesnt match the predicate, right? http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: PS2, Line 599: type; get the type name (from the type info) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/common/column_predicate.h File src/kudu/common/column_predicate.h: PS2, Line 199: EvaluateCell docs http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/tablet/tablet-scan-correctness-test.cc File src/kudu/tablet/tablet-scan-correctness-test.cc: PS2, Line 116: result count to counter "result count in 'counter'" PS2, Line 116: missing "a" PS2, Line 413: class AlteredTabletCorrectnessTest : public TabletCorrectnessTest is the problem just on int32 or on other types too? is there anything to gain by making this a typed test (like in all_types-itest)? Feel free to push back if you think it doesn't buy us all that much. PS2, Line 413: class AlteredTabletCorrectnessTest : public TabletCorrectnessTest { Are we testing, or at least sure, this works both decoder level eval and normal eval? PS2, Line 422: void AlterTable(const void* read_default, const void* write_default) { blank line above this method, docs PS2, Line 454: CheckResults doc this PS2, Line 512: This should yield the same results as the query on : // val_b where val_c is not null. can you make sure the results match then? -- To view, visit http://gerrit.cloudera.org:8080/6129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
