Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#7). Change subject: KUDU-1893 Ensure evaluation of added columns ...................................................................... KUDU-1893 Ensure evaluation of added columns During a normal scan, a CFileIterator sets a flag to indicate whether the block supports decoder-level evaluation, and if, after returning, this flag has not been set to false, the returned data will be evaluated against the predicate. Columns that are added after table creation and after a flush will use DefaultColumnValueIterators to scan. These iterators were not setting the flag, so the predicates would not be evaluated on these columns. All rows in the existing resuls set would be returned, regardless of predicates on added columns. This patch addresses this by forcing predicate evaluation by the DefaultColumnValueIterator. Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 --- M src/kudu/cfile/cfile_reader.cc M src/kudu/common/column_predicate.cc M src/kudu/common/column_predicate.h M src/kudu/tablet/all_types-scan-correctness-test.cc 4 files changed, 362 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6129/7 -- To view, visit http://gerrit.cloudera.org:8080/6129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <ram.me...@rms.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>