Alexey Serbin has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6134/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 812: LOG(INFO) << "No active consensus, ignoring callback"; > Let's change this to WARNING. Done Line 991: return RaftPeerPB::UNKNOWN_ROLE; > When is this method invoked? Will returning UNKNOWN_ROLE be OK? It's used in MasterServiceImpl::GetMasterRegistration() and MasterServiceImpl::ConnectToMaster() RPC handlers. It sets the 'role' field in GetMasterRegistrationResponsePB and ConnectToMasterResponsePB correspondingly. As far as I can see, the callers might expect that field to be set to UNKNOWN value. Line 1025: // on the system table, if any. > Let's be more explicit and explain how it's important to do this before wai Done Line 1034: // Wait for any outstanding table visitors to finish. > Can you reword this comment so it's talking about the ElectedLeaderCb task? Done -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad66fe33d4696adf2a02a09e2790afa8869583 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
