Alexey Serbin has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6134/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS4, Line 722: scoped_refptr<Consensus> consensus = : sys_catalog_->tablet_peer()->shared_consensus(); : if (!consensus || !consensus->IsRunning()) { : return Status::IllegalState("no active consensus"); : } > are we totally sure about destruction order? is there a race where consensu The WaitUntilCaughtUpAsLeader method is called only by the 'elected-as-a-leader' task. The shutdown sequence awaits for that task to complete before shutting down the tablet peer, so no race like described is expected. And that sequence is crucial: there more places in the code called by the task which requires tablet peer to be non-null when the task runs. PS4, Line 1029: is > are Done -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad66fe33d4696adf2a02a09e2790afa8869583 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
