David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6159/2/src/kudu/cfile/binary_plain_block.cc File src/kudu/cfile/binary_plain_block.cc: PS2, Line 200: if (PREDICT_FALSE(p > limit)) { : // Only need to check 'p' overrun in the slow path - see above DCHECK. : LOG(WARNING) << "bad block: " << HexDump(data_); : return Status::Corruption(StringPrintf("unable to decode offsets in block")); : } not sure I follow, why a DCHECK in the fast patch and just a warning in the slow path? http://gerrit.cloudera.org:8080/#/c/6159/2/src/kudu/cfile/binary_plain_block.h File src/kudu/cfile/binary_plain_block.h: PS2, Line 142: offset docs -- To view, visit http://gerrit.cloudera.org:8080/6159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b5061818de36dc268cd5d4fc8553bceeca5dadd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
