David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6159/2/src/kudu/cfile/binary_plain_block.cc File src/kudu/cfile/binary_plain_block.cc: PS2, Line 200: else { : p = coding::DecodeGroupVarInt32_SlowButSafe( : p, &dst_ptr[0], &dst_ptr[1], &dst_ptr[2], &dst_ptr[3]); : if (PREDICT_FALSE(p > limit)) { : > per the comment above, in the fast path, the function can add at most 17 to mind adding the latter part of your answer to the comment on the slow path? -- To view, visit http://gerrit.cloudera.org:8080/6159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b5061818de36dc268cd5d4fc8553bceeca5dadd Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
