Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. ......................................................................
Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: Line 1087: ASSERT_NE("", gflags::SetCommandLineOption("redact", "log")); > So this reruns the validator? Is that how the log boolean gets reset? Yeah, according to gflags doc, SetCommandLineOption would trigger validator. http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 150: vector<string>::const_iterator iter; > You can use an enhanced for loop: Done Line 165: if (!is_valid) { > Why don't we store the result of FLAG redaction in a global variable too? T Done http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/util/flags.h File src/kudu/util/flags.h: Line 68: #endif /* KUDU_UTIL_FLAGS_H */ > Why do we still need this? Either logging.h should call this and should_red Done http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/util/logging.cc File src/kudu/util/logging.cc: Line 80: bool g_should_redact_log; > Does this actually need a default value, since it's always initialized via Done http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/util/logging.h File src/kudu/util/logging.h: Line 86: extern bool g_should_redact_log; > Nit: we generally prefix global variables with g_. Done -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia49ae439824351df6c87291b0828173c69ab31b0 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
