Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 327: bool g_should_redact_flag; Let's also declare this one in the header, so it's even more consistent with g_should_redact_log. It'll make it easier for someone else to see what they need to do when adding a new redaction type in the future. -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia49ae439824351df6c87291b0828173c69ab31b0 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
