David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1506 Add consensus lag metrics ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS3, Line 1047: queue_->UpdateLagMetrics(request->max_replicated_index()); > I'd wanted to keep it separate since only the lag metric will be updated ri The leader's validity is only checked in LOC 1145, so this would have to be below at least LOC 1151. That being said I do see the point of updating this even if we can't prepare (if block in 1183). Actually we probably need this particularly bad _when_ we can't prepare, so I'm ok with keeping two separate methods. -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
