Andrew Wong has posted comments on this change. Change subject: WIP: KUDU-1506 Add consensus lag metrics ......................................................................
Patch Set 6: > Is there any way we can get this metric to be time-based instead of > op-based? op-based has the downside that it's dependent on the rate > of incoming operations? I know the above mentioned time-based doesn't measure the same thing, but it's lower-hanging and still potentially useful. To convert this follower lag metric to time, I think we can keep track of when we append each op on the leader side and add to the follower request the time that the leader appended the last op in the request. There're some implementation details (e.g. upper bound on time) missing, but I think that might work. -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No