Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 15: (5 comments) TFTR Mike/David again. We could follow up TimeManager friend method suggestion in an upcoming patch. http://gerrit.cloudera.org:8080/#/c/6066/15/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1605: if (!IsRaftConfigVoter(local_peer_uuid, committed_config)) { > How about we just move this down to line 1649 and say: Done Line 1633: if (!ContainsKey(retained_peer_uuids, local_peer_uuid)) { > This seems redundant with the voter check if we do the voter check on the n Done PS15, Line 1646: continue; > unnecessary Done http://gerrit.cloudera.org:8080/#/c/6066/15/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: PS15, Line 171: LOG(INFO) > How about VLOG(1) here and below? thanks for catching, some leftover debugging. Line 920: > Let's keep the master dead until here, then run Done -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
