Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 16: (9 comments) TFTR Mike again, updated now. http://gerrit.cloudera.org:8080/#/c/6066/17//COMMIT_MSG Commit Message: PS17, Line 24: he s > "fake" Done PS17, Line 40: > UnsafeChangeConfig Done http://gerrit.cloudera.org:8080/#/c/6066/17/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS17, Line 778: . > Nit: please also add a space after this period (and all periods) Done PS17, Line 780: , > please add a space after this comma (and all commas) Done http://gerrit.cloudera.org:8080/#/c/6066/16/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS16, Line 1635: tablet $1 > Use SecureShortDebugString() from pb_util.h Done http://gerrit.cloudera.org:8080/#/c/6066/17/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1597: } > Use SecureShortDebugString() from pb_util.h: Done PS17, Line 1694: > SecureShortDebugString(committed_config) Done PS17, Line 1695: > SecureShortDebugString(new_config) Done http://gerrit.cloudera.org:8080/#/c/6066/16/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: PS16, Line 366: LOG(WARNING) << "NOTE: the new config may be replicated asynchronously " : << "to other peers and it may take a while to bring the tablet " : << "back to majority replica count depending upon how much time " : << "the new peer replicas take to catch up with the tablet server " : << "enforcing the new config."; > It's still there in rev 17. Done, removed now, yeah looks like I pressed 'done' before updating this code :) -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <dinesha...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <dinesha...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
