Adar Dembo has posted comments on this change.

Change subject: KUDU-1966: Data directories can be removed erroneously
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6589/1/src/kudu/fs/block_manager_util.cc
File src/kudu/fs/block_manager_util.cc:

Line 164:       // Check that all of the expected paths are present.
> My thought was that all of the error messages in this method are unintuitiv
I can buy that, but the errors (and comments) should at least be consistent 
with one another, and right now this one stands out from the others.


-- 
To view, visit http://gerrit.cloudera.org:8080/6589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1565069a3a596ddb41507dd95dd93dc85e021fbd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to