Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/2/src/kudu/fs/block_manager_util.cc File src/kudu/fs/block_manager_util.cc: Line 164: // Check that all of the expected uuids are present. There's something that still seems unintuitive about this check to me. Maybe it's because it's inside the loop (which is weird because this should only happen once), or because it's comparing container sizes instead of contents. What if, outside the loop, we compared first_all_uuids.first with JoinStrings(uuids.keys, ",")? I think I'd find that more intuitive; do you as well? -- To view, visit http://gerrit.cloudera.org:8080/6589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1565069a3a596ddb41507dd95dd93dc85e021fbd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
