David Ribeiro Alves has posted comments on this change. Change subject: fs: generate report during Open ......................................................................
Patch Set 1: (11 comments) first round of reviews. this patch is pretty heftly so I'll review it in 2-3 rounds or less. rather do that than leave no feedback until I'm done http://gerrit.cloudera.org:8080/#/c/6581/1//COMMIT_MSG Commit Message: PS1, Line 32: previously only the opposite was true. what is the opposite? http://gerrit.cloudera.org:8080/#/c/6581/1/src/kudu/fs/fs_report.h File src/kudu/fs/fs_report.h: PS1, Line 34: prefix with: "Error type:" same for the cases below Line 45: nit no need for an empty line, same for the structs below PS1, Line 56: deletes this doesn't delete anything right? maybe rephrase to: "(can be repaired by deleting the block) though I'd be okay to just omit this altogether PS1, Line 77: preallocated pre-allocated PS1, Line 77: container containers PS1, Line 80: truncates the container data files same comment as in the previous struct PS1, Line 101: Checks for LBM containers where one or both files are too short to be of use. care to elaborate on this? not sure I understand how files can be too short. were they truncated? (in which case how is this repairable?) PS1, Line 199: Fatal and repairable isn't a repairable inconsistency by definition non-fatal? how about just: - fatal - repairable - irreparable PS1, Line 217: // Returns whether this report describes at least one fatal and irreparable : // inconsistency. : bool HasFatalErrors() const; this method name and comment seems to agree with my comment on the struct header PS1, Line 226: // Like CheckForFatalErrors(), but also writes the report to LOG(INFO). : Status LogAndCheckForFatalErrors() const; : : // Like CheckForFatalErrors(), but also writes the report to stdout. : Status PrintAndCheckForFatalErrors() const; do there really belong here?, why not just pass a report all the time and then let the called decide what to do with it? (print it or log it or whatever) -- To view, visit http://gerrit.cloudera.org:8080/6581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcc1d512e2bed103c8d41623a63b4d071532b35e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
