Todd Lipcon has posted comments on this change. Change subject: fs: generate report during Open ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6581/4/src/kudu/fs/fs_report.cc File src/kudu/fs/fs_report.cc: PS4, Line 56: auto& missing_blocks = LookupOrInsert(&missing_blocks_by_tablet_id, : mb.tablet_id, vector<string>()); : missing_blocks.emplace_back(mb.block_id.ToString()); I think you can use operator[]'s auto-construction magic here and just do: missing_blocks_by_tablet_id[mb.tablet_id].emplace_back(mb.block_id.ToString()) -- To view, visit http://gerrit.cloudera.org:8080/6581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcc1d512e2bed103c8d41623a63b4d071532b35e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
