Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#2). Change subject: log block manager: use extent maps to decide whether to truncate containers ...................................................................... log block manager: use extent maps to decide whether to truncate containers This patch wires the new GetExtentMap() method into the LBM for use in determining whether there exists allocated disk space beyond the container data file's logical size. Why bother? Well, it's not possible for the "full container preallocation" accounting in FsReport to be accurate otherwise. Also, reducing the number of cases wherein containers are truncated ought to be safer. Finally, we'll eventually use the extent map for other purposes (e.g. repunching holes efficiently at startup). My first implementation required LBM users to have GetExtentMap()-compatible systems. Testing showed this to be safe across Kudu's supported distro and filesystem matrix. The notable exception was aufs, used by Docker containers that run our pre-commit tests. It would be unfortunate if Kudu were unusable in Docker [1], so I adjusted the behavior to be more forgiving. I also snuck in some cosmetic changes to a few error messages. 1. Though isn't KUDU-1419 still an issue? Maybe not in all versions of aufs? Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8 --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc 3 files changed, 92 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/6585/2 -- To view, visit http://gerrit.cloudera.org:8080/6585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>