David Ribeiro Alves has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6585/3/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: PS3, Line 595: supports_get_extent_map nit: can you use this var name in the method arg as well? http://gerrit.cloudera.org:8080/#/c/6585/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS3, Line 282: thread unsafe. nit: "not thread safe" PS3, Line 555: *excess_bytes = 0; is the value of the arg meaningful on a non-OK status? if so maybe comment on the method, if not maybe not set it? -- To view, visit http://gerrit.cloudera.org:8080/6585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
