David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6574/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 371: void AssertRawDataMatches(const KuduSchema& projection_schema, > mind adding a simple comment here? Done http://gerrit.cloudera.org:8080/#/c/6574/7/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 130: const Slice& direct_data() const; > why return Slice& instead of just Slice? usually we use pass-by-value for S Done Line 135: const Slice& indirect_data() const; > same Done -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
