Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 11: (1 comment) Looks good to me overall, just one little question to clarify on the client-test.cc code. http://gerrit.cloudera.org:8080/#/c/6574/11/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 391: Is it worth adding something like ASSERT_EQ(4, num_projected_cols); after that if (num_projected_cols == 1) ? If it's acceptable/necessary to skip checks for other columns in case of different number of num_projected_cols not making that ASSERT check, it would be nice to have a comment about that. It seems it was 'if (num_projected_cols != 4) return;' in one of the prior versions, and then after my comment you updated it to be like this. Actually, I just wanted to understand: what is the desired behavior of this method in case of other numbers of columns. So, it seems a comment for that 'if ()' would not hurt :) -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
