Adar Dembo has posted comments on this change. Change subject: WIP: Expose a way to set "advanced" non-types scan options ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6624/4//COMMIT_MSG Commit Message: PS4, Line 15: without "polluting" the api and in such a way that we can remove : support for this in the future. > Thanks for weighing in. Regarding this advanced option API, is an enum constant strong enough? I understand how it will surface an API removal as a breakage at compile time, but if an existing application binary is used, will the removal manifest as a link time error or a run time error? Regarding API development, I had drafted a response comparing the Linux syscall API to Guava and Hadoop's APIs, but I don't think it'll be a productive discussion. It's clear to me that I would prefer if unstable APIs in Kudu were highly discouraged if not prohibited outright, and if Kudu's API culture were more egalitarian (i.e. consumer "weight" didn't play a role in dictating exceptions from the "no unstable APIs" rule). But, I appear to be in the minority, and this isn't the right forum for that discussion. So consider it dropped. -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
