Matthew Jacobs has posted comments on this change. Change subject: WIP: Expose a way to set "advanced" non-types scan options ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6624/4/src/kudu/client/scan_configuration.cc File src/kudu/client/scan_configuration.cc: PS4, Line 184: if (strcasecmp(name.c_str(), kPadUnixTimeMicrosScanOption)) { here and below, this isn't going to do what you want it to. strcasecmp returns 0 if they're equal PS4, Line 186: pad_unixtime_micros_for_impala_ return OK after this and below, otherwise you'll return the error on l195 PS4, Line 187: true false? also compare is used wrong http://gerrit.cloudera.org:8080/#/c/6624/4/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: Line 377: // Whether the server supports padding UNIXTIME_MICROS slots. something doesn't seem hooked up correctly, when I play with this I'm getting Remote error: unsupported feature flags -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
