Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6640/4/src/kudu/integration-tests/security-unknown-tsk-itest.cc File src/kudu/integration-tests/security-unknown-tsk-itest.cc: Line 50: //DECLARE_int32(heartbeat_rpc_timeout_ms); remove these? PS4, Line 83: torun typo Line 128: ASSERT_NE(boost::none, authn_token); I think this can be simplified to ASSERT(authn_token); Line 152: ASSERT_OK(table_creator->table_name(kTableName) When I initially read this, I got confused because I expected this to fail due to the invalid token, then I remembered that the master connection is probably already cached. Is that right? You may want to create the table before switching out the token just for clarity. Line 174: auto cleanup = MakeScopedCleanup([&]() { Might be simpler to use ElementDeleter from stl_util.h -- To view, visit http://gerrit.cloudera.org:8080/6640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
