Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6640/6/src/kudu/integration-tests/security-unknown-tsk-itest.cc File src/kudu/integration-tests/security-unknown-tsk-itest.cc: Line 96: FLAGS_rpc_default_keepalive_time_ms = kConnectionKeepaliveMs_; > As I understand, setting this flag here does set that parameter on the serv Oh ok, I figured it was an external mini cluster since its an itest. Sounds good. Line 175: for (int i = 0; i < num_tablet_servers_; ++i) { > It seems I forgot to comment on this in the code -- will do. This isn't quite accurate - the master will return more tablets than requested. In this case I believe the client never goes back to the master for locations. Regardless, I think it would be better and simpler to explicitly call a master RPC if that's the intent - for example ListTables. Line 279: atomic<bool> importer_do_run(true); > That's mostly for failure scenarios when something goes wrong in the code b ah, so it's just a short-circuit? -- To view, visit http://gerrit.cloudera.org:8080/6640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
