Adar Dembo has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc File src/kudu/gutil/atomicops-internals-x86.cc: Line 70: static void AtomicOps_Internalx86CPUFeaturesInit() { Is this guaranteed to load before glog? If not, what will happen in the LOG(FATAL) call below? Why not just rename AtomicOps_x86CPUFeatureStruct (and stick to the original patch where this method is explicitly called) so there's no collision with the struct variant from tcmalloc? Or wrap it all in another namespace? -- To view, visit http://gerrit.cloudera.org:8080/6680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
